Conversation
whummer
left a comment
There was a problem hiding this comment.
Overall looks great, kudos for churning out this sample app @HarshCasper ! 🚀
I was just having some issues running the Web app - can you please confirm if the script.js is missing in the repo, or did I miss any of the installation commands?
|
Btw, just asked Claude for a review of the branch, just out of curiosity, and for comparison. Some of the points I've mentioned above are also included in there, and there are some additional nitpick comments (which I don't think are that important, tbh). Just wanted to share.. 🙂 👍 |
There was a problem hiding this comment.
Thanks for updating the PR @HarshCasper - just tested the sample app, works like a charm locally! 🚀
My only question would be (actually unrelated to this PR) - should we rename the extension from localstack-extension-paradedb to simply localstack-paradedb in pyproject.toml..? This is also related to the comment in #127 - would allow us to be consistent in the naming and more in line with the existing localstack-wiremock. (we haven't published the ParadeDB extension yet, so could be an opportunity to still change it at this point 👍 )
Summary
Preview